Remove unused HttpServletRequest and HttpServletResponse parameters Change-Id: Ifddb3dc7aa09c4c72c16959e7fe3065408f55924
diff --git a/java/com/google/gitiles/DescribeServlet.java b/java/com/google/gitiles/DescribeServlet.java index ebd2ea4..ae1d4c8 100644 --- a/java/com/google/gitiles/DescribeServlet.java +++ b/java/com/google/gitiles/DescribeServlet.java
@@ -53,7 +53,7 @@ @Override protected void doGetText(HttpServletRequest req, HttpServletResponse res) throws IOException { - String name = describe(ServletUtils.getRepository(req), ViewFilter.getView(req), req, res); + String name = describe(ServletUtils.getRepository(req), ViewFilter.getView(req), req); if (name == null) { return; } @@ -64,7 +64,7 @@ @Override protected void doGetJson(HttpServletRequest req, HttpServletResponse res) throws IOException { - String name = describe(ServletUtils.getRepository(req), ViewFilter.getView(req), req, res); + String name = describe(ServletUtils.getRepository(req), ViewFilter.getView(req), req); if (name == null) { return; } @@ -75,9 +75,7 @@ new TypeToken<Map<String, String>>() {}.getType()); } - private ObjectId resolve( - Repository repo, GitilesView view, HttpServletRequest req, HttpServletResponse res) - throws IOException { + private ObjectId resolve(Repository repo, GitilesView view) throws IOException { String rev = view.getPathPart(); try { return repo.resolve(rev); @@ -93,19 +91,18 @@ } } - private String describe( - Repository repo, GitilesView view, HttpServletRequest req, HttpServletResponse res) + private String describe(Repository repo, GitilesView view, HttpServletRequest req) throws IOException { if (!getBooleanParam(view, CONTAINS_PARAM)) { throw new GitilesRequestFailureException(FailureReason.INCORECT_PARAMETER); } - ObjectId id = resolve(repo, view, req, res); + ObjectId id = resolve(repo, view); if (id == null) { return null; } String name; try (Git git = new Git(repo)) { - NameRevCommand cmd = nameRevCommand(git, id, req, res); + NameRevCommand cmd = nameRevCommand(git, id, req); if (cmd == null) { return null; } @@ -119,8 +116,8 @@ return name; } - private NameRevCommand nameRevCommand( - Git git, ObjectId id, HttpServletRequest req, HttpServletResponse res) throws IOException { + private NameRevCommand nameRevCommand(Git git, ObjectId id, HttpServletRequest req) + throws IOException { GitilesView view = ViewFilter.getView(req); NameRevCommand cmd = git.nameRev(); boolean all = getBooleanParam(view, ALL_PARAM);