Remove unused guice dependency Guice doesn't seem to be used. Remove it and all it transitive dependencies. Also remove specifications for error prone bug patterns related to dependency injection. Change-Id: I0edfb951e292ed583a16743a5f8ea9b35d76f397
diff --git a/WORKSPACE b/WORKSPACE index d04ed9e..cedda34 100644 --- a/WORKSPACE +++ b/WORKSPACE
@@ -257,32 +257,6 @@ sha1 = "a41f9cfe6faafb2eb83a1c7dd2d0dfd844e2a936", ) -GUICE_VERSION = "5.0.1" - -maven_jar( - name = "guice-library", - artifact = "com.google.inject:guice:" + GUICE_VERSION, - sha1 = "0dae7556b441cada2b4f0a2314eb68e1ff423429", -) - -maven_jar( - name = "guice-assistedinject", - artifact = "com.google.inject.extensions:guice-assistedinject:" + GUICE_VERSION, - sha1 = "62e02f2aceb7d90ba354584dacc018c1e94ff01c", -) - -maven_jar( - name = "aopalliance", - artifact = "aopalliance:aopalliance:1.0", - sha1 = "0235ba8b489512805ac13a8f9ea77a1ca5ebe3e8", -) - -maven_jar( - name = "javax-inject", - artifact = "javax.inject:javax.inject:1", - sha1 = "6975da39a7040257bd51d21a231b76c915872d38", -) - JETTY_VERSION = "9.4.49.v20220914" maven_jar(
diff --git a/java/com/google/gitiles/BUILD b/java/com/google/gitiles/BUILD index 427ef17..51c568c 100644 --- a/java/com/google/gitiles/BUILD +++ b/java/com/google/gitiles/BUILD
@@ -25,7 +25,6 @@ DEPS_ALL = DEPS + [ "//lib:jgit-archive", - "//lib/guice:guice", ] java_library(
diff --git a/lib/guice/BUILD b/lib/guice/BUILD deleted file mode 100644 index 188f2cc..0000000 --- a/lib/guice/BUILD +++ /dev/null
@@ -1,25 +0,0 @@ -load("@rules_java//java:defs.bzl", "java_library") - -package( - default_visibility = ["//visibility:public"], -) - -java_library( - name = "guice", - exports = [ - ":aopalliance", - ":guice-assistedinject", - ":guice-library", - ":javax-inject", - ], -) - -[java_library( - name = n, - runtime_deps = ["@%s//jar" % n], -) for n in [ - "guice-library", - "guice-assistedinject", - "javax-inject", - "aopalliance", -]]
diff --git a/tools/BUILD b/tools/BUILD index 500e197..93b779e 100644 --- a/tools/BUILD +++ b/tools/BUILD
@@ -60,7 +60,6 @@ "-Xep:ImmutableAnnotationChecker:ERROR", "-Xep:ImmutableEnumChecker:WARN", "-Xep:IncompatibleModifiers:ERROR", - "-Xep:InjectOnConstructorOfAbstractClass:ERROR", "-Xep:InputStreamSlowMultibyteRead:ERROR", "-Xep:IterableAndIterator:ERROR", "-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR", @@ -77,7 +76,6 @@ "-Xep:NullablePrimitive:ERROR", "-Xep:NullableVoid:ERROR", "-Xep:OperatorPrecedence:ERROR", - "-Xep:OverridesGuiceInjectableMethod:ERROR", "-Xep:PreconditionsInvalidPlaceholder:ERROR", "-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR", "-Xep:ProtocolBufferOrdinal:ERROR",