Update to JGit 3.0 API Change-Id: I6364962dde8ee348ab2fca718f08a7010bcd56b4
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/ConfigUtilTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/ConfigUtilTest.java index 96439c2..c5c8389 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/ConfigUtilTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/ConfigUtilTest.java
@@ -15,7 +15,6 @@ package com.google.gitiles; import static com.google.gitiles.ConfigUtil.getDuration; - import junit.framework.TestCase; import org.eclipse.jgit.lib.Config;
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/FakeHttpServletRequest.java b/gitiles-servlet/src/test/java/com/google/gitiles/FakeHttpServletRequest.java index 7b70400..d073c80 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/FakeHttpServletRequest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/FakeHttpServletRequest.java
@@ -19,17 +19,6 @@ import static com.google.common.base.Preconditions.checkNotNull; import static com.google.gitiles.TestGitilesUrls.URLS; -import com.google.common.base.Function; -import com.google.common.base.Splitter; -import com.google.common.collect.ImmutableList; -import com.google.common.collect.Iterables; -import com.google.common.collect.LinkedListMultimap; -import com.google.common.collect.ListMultimap; -import com.google.common.collect.Maps; - -import org.eclipse.jgit.http.server.ServletUtils; -import org.eclipse.jgit.storage.dfs.DfsRepository; - import java.io.BufferedReader; import java.io.UnsupportedEncodingException; import java.net.URLDecoder; @@ -47,6 +36,17 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpSession; +import org.eclipse.jgit.http.server.ServletUtils; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; + +import com.google.common.base.Function; +import com.google.common.base.Splitter; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Iterables; +import com.google.common.collect.LinkedListMultimap; +import com.google.common.collect.ListMultimap; +import com.google.common.collect.Maps; + /** Simple fake implementation of {@link HttpServletRequest}. */ public class FakeHttpServletRequest implements HttpServletRequest { public static final String SERVLET_PATH = "/b";
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/FakeHttpServletResponse.java b/gitiles-servlet/src/test/java/com/google/gitiles/FakeHttpServletResponse.java index a6c90e3..85da54f 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/FakeHttpServletResponse.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/FakeHttpServletResponse.java
@@ -19,14 +19,6 @@ import static com.google.common.base.Preconditions.checkNotNull; import static com.google.common.base.Preconditions.checkState; -import com.google.common.base.Charsets; -import com.google.common.collect.Iterables; -import com.google.common.collect.LinkedListMultimap; -import com.google.common.collect.ListMultimap; -import com.google.common.net.HttpHeaders; - -import org.eclipse.jgit.util.RawParseUtils; - import java.io.ByteArrayOutputStream; import java.io.IOException; import java.io.PrintWriter; @@ -37,6 +29,14 @@ import javax.servlet.http.Cookie; import javax.servlet.http.HttpServletResponse; +import org.eclipse.jgit.util.RawParseUtils; + +import com.google.common.base.Charsets; +import com.google.common.collect.Iterables; +import com.google.common.collect.LinkedListMultimap; +import com.google.common.collect.ListMultimap; +import com.google.common.net.HttpHeaders; + /** Simple fake implementation of {@link HttpServletResponse}. */ public class FakeHttpServletResponse implements HttpServletResponse { private final ByteArrayOutputStream actualBody = new ByteArrayOutputStream();
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/GitilesFilterTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/GitilesFilterTest.java index 0d32dd4..dde2297 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/GitilesFilterTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/GitilesFilterTest.java
@@ -18,10 +18,10 @@ import static com.google.gitiles.GitilesFilter.REPO_REGEX; import static com.google.gitiles.GitilesFilter.ROOT_REGEX; -import junit.framework.TestCase; - import java.util.regex.Matcher; +import junit.framework.TestCase; + /** Tests for the Gitiles filter. */ public class GitilesFilterTest extends TestCase { public void testRootUrls() throws Exception {
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/GitilesUrlsTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/GitilesUrlsTest.java index 4c2ff8b..d262f47 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/GitilesUrlsTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/GitilesUrlsTest.java
@@ -15,7 +15,6 @@ package com.google.gitiles; import static com.google.gitiles.GitilesUrls.NAME_ESCAPER; - import junit.framework.TestCase; /** Unit tests for {@link GitilesUrls}. */
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/GitilesViewTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/GitilesViewTest.java index fb28533..3cc846e 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/GitilesViewTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/GitilesViewTest.java
@@ -14,15 +14,15 @@ package com.google.gitiles; +import junit.framework.TestCase; + +import org.eclipse.jgit.lib.ObjectId; + import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableListMultimap; import com.google.common.collect.ImmutableMap; import com.google.gitiles.GitilesView.Type; -import junit.framework.TestCase; - -import org.eclipse.jgit.lib.ObjectId; - /** Tests for Gitiles views. */ public class GitilesViewTest extends TestCase { private static final GitilesView HOST = GitilesView.hostIndex()
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/GitwebRedirectFilterTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/GitwebRedirectFilterTest.java index 3f2645a..b552ff6 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/GitwebRedirectFilterTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/GitwebRedirectFilterTest.java
@@ -16,22 +16,21 @@ import static com.google.gitiles.FakeHttpServletRequest.SERVLET_PATH; import static com.google.gitiles.TestGitilesUrls.HOST_NAME; - import static javax.servlet.http.HttpServletResponse.SC_GONE; import static javax.servlet.http.HttpServletResponse.SC_MOVED_PERMANENTLY; -import com.google.common.net.HttpHeaders; +import javax.servlet.http.HttpServletRequest; import junit.framework.TestCase; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; +import org.eclipse.jgit.internal.storage.dfs.DfsRepositoryDescription; +import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; import org.eclipse.jgit.junit.TestRepository; import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.revwalk.RevCommit; -import org.eclipse.jgit.storage.dfs.DfsRepository; -import org.eclipse.jgit.storage.dfs.DfsRepositoryDescription; -import org.eclipse.jgit.storage.dfs.InMemoryRepository; -import javax.servlet.http.HttpServletRequest; +import com.google.common.net.HttpHeaders; /** Tests for gitweb redirector. */ public class GitwebRedirectFilterTest extends TestCase {
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/LinkifierTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/LinkifierTest.java index 6f6caf2..a943b2f 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/LinkifierTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/LinkifierTest.java
@@ -14,12 +14,12 @@ package com.google.gitiles; -import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableMap; +import javax.servlet.http.HttpServletRequest; import junit.framework.TestCase; -import javax.servlet.http.HttpServletRequest; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; /** Tests for {@link Linkifier}. */ public class LinkifierTest extends TestCase {
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/PaginatorTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/PaginatorTest.java index 09661f2..4f8b30b 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/PaginatorTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/PaginatorTest.java
@@ -16,19 +16,19 @@ import static com.google.common.base.Preconditions.checkArgument; -import com.google.common.collect.ImmutableList; -import com.google.common.collect.Lists; +import java.util.List; import junit.framework.TestCase; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; +import org.eclipse.jgit.internal.storage.dfs.DfsRepositoryDescription; +import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; import org.eclipse.jgit.junit.TestRepository; import org.eclipse.jgit.revwalk.RevCommit; import org.eclipse.jgit.revwalk.RevWalk; -import org.eclipse.jgit.storage.dfs.DfsRepository; -import org.eclipse.jgit.storage.dfs.DfsRepositoryDescription; -import org.eclipse.jgit.storage.dfs.InMemoryRepository; -import java.util.List; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Lists; /** Unit tests for {@link LogServlet}. */ public class PaginatorTest extends TestCase {
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/PathsTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/PathsTest.java index e7cd492..09d4ccb 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/PathsTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/PathsTest.java
@@ -15,7 +15,6 @@ package com.google.gitiles; import static com.google.gitiles.Paths.simplifyPathUpToRoot; - import junit.framework.TestCase; /** Tests for {@link Paths}. */
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/RefServletTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/RefServletTest.java index 9e8bac4..bb9427d 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/RefServletTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/RefServletTest.java
@@ -14,18 +14,18 @@ package com.google.gitiles; +import java.io.IOException; + import junit.framework.TestCase; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; +import org.eclipse.jgit.internal.storage.dfs.DfsRepositoryDescription; +import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; import org.eclipse.jgit.junit.TestRepository; import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.lib.Repository; import org.eclipse.jgit.revwalk.RevCommit; import org.eclipse.jgit.revwalk.RevTag; -import org.eclipse.jgit.storage.dfs.DfsRepository; -import org.eclipse.jgit.storage.dfs.DfsRepositoryDescription; -import org.eclipse.jgit.storage.dfs.InMemoryRepository; - -import java.io.IOException; /** Tests for {@link Linkifier}. */ public class RefServletTest extends TestCase {
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/RepositoryIndexServletTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/RepositoryIndexServletTest.java index 7a93191..2045dc6 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/RepositoryIndexServletTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/RepositoryIndexServletTest.java
@@ -16,21 +16,21 @@ import static com.google.gitiles.TestGitilesUrls.URLS; -import com.google.common.collect.ImmutableList; -import com.google.common.collect.ImmutableMap; - -import junit.framework.TestCase; - -import org.eclipse.jgit.junit.TestRepository; -import org.eclipse.jgit.storage.dfs.DfsRepository; -import org.eclipse.jgit.storage.dfs.DfsRepositoryDescription; -import org.eclipse.jgit.storage.dfs.InMemoryRepository; - import java.io.IOException; import java.util.Map; import javax.servlet.http.HttpServletRequest; +import junit.framework.TestCase; + +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; +import org.eclipse.jgit.internal.storage.dfs.DfsRepositoryDescription; +import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; +import org.eclipse.jgit.junit.TestRepository; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; + /** Tests for {@link RepositoryIndexServlet}. */ public class RepositoryIndexServletTest extends TestCase { private TestRepository<DfsRepository> repo;
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/RevisionParserTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/RevisionParserTest.java index d2480f9..a636a17 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/RevisionParserTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/RevisionParserTest.java
@@ -17,19 +17,18 @@ import static org.eclipse.jgit.lib.Constants.OBJ_BLOB; import static org.eclipse.jgit.lib.Constants.OBJ_COMMIT; import static org.eclipse.jgit.lib.Constants.OBJ_TAG; - -import com.google.common.cache.CacheBuilder; -import com.google.gitiles.RevisionParser.Result; - import junit.framework.TestCase; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; +import org.eclipse.jgit.internal.storage.dfs.DfsRepositoryDescription; +import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; import org.eclipse.jgit.junit.TestRepository; import org.eclipse.jgit.revwalk.RevBlob; import org.eclipse.jgit.revwalk.RevCommit; import org.eclipse.jgit.revwalk.RevTag; -import org.eclipse.jgit.storage.dfs.DfsRepository; -import org.eclipse.jgit.storage.dfs.DfsRepositoryDescription; -import org.eclipse.jgit.storage.dfs.InMemoryRepository; + +import com.google.common.cache.CacheBuilder; +import com.google.gitiles.RevisionParser.Result; /** Tests for the revision parser. */ public class RevisionParserTest extends TestCase {
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/TestGitilesAccess.java b/gitiles-servlet/src/test/java/com/google/gitiles/TestGitilesAccess.java index b9607ae..a511d40 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/TestGitilesAccess.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/TestGitilesAccess.java
@@ -16,15 +16,15 @@ import static com.google.common.base.Preconditions.checkNotNull; -import com.google.common.collect.ImmutableMap; - -import org.eclipse.jgit.storage.dfs.DfsRepository; - import java.util.Map; import java.util.Set; import javax.servlet.http.HttpServletRequest; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; + +import com.google.common.collect.ImmutableMap; + /** Gitiles access for testing. */ public class TestGitilesAccess implements GitilesAccess.Factory { private final DfsRepository repo;
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/TestGitilesServlet.java b/gitiles-servlet/src/test/java/com/google/gitiles/TestGitilesServlet.java index ee7b6ac..6b4579a 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/TestGitilesServlet.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/TestGitilesServlet.java
@@ -14,15 +14,6 @@ package com.google.gitiles; -import com.google.common.collect.ImmutableList; - -import org.eclipse.jgit.errors.RepositoryNotFoundException; -import org.eclipse.jgit.junit.TestRepository; -import org.eclipse.jgit.lib.Config; -import org.eclipse.jgit.lib.Repository; -import org.eclipse.jgit.storage.dfs.DfsRepository; -import org.eclipse.jgit.transport.resolver.RepositoryResolver; - import java.util.Collections; import java.util.Enumeration; @@ -31,6 +22,15 @@ import javax.servlet.ServletException; import javax.servlet.http.HttpServletRequest; +import org.eclipse.jgit.errors.RepositoryNotFoundException; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; +import org.eclipse.jgit.junit.TestRepository; +import org.eclipse.jgit.lib.Config; +import org.eclipse.jgit.lib.Repository; +import org.eclipse.jgit.transport.resolver.RepositoryResolver; + +import com.google.common.collect.ImmutableList; + /** Static utility methods for creating {@link GitilesServlet}s for testing. */ public class TestGitilesServlet { /** @see #create(TestRepository) */
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/TimeCacheTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/TimeCacheTest.java index f8c397c..c839f37 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/TimeCacheTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/TimeCacheTest.java
@@ -14,8 +14,13 @@ package com.google.gitiles; +import java.io.IOException; + import junit.framework.TestCase; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; +import org.eclipse.jgit.internal.storage.dfs.DfsRepositoryDescription; +import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; import org.eclipse.jgit.junit.TestRepository; import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.lib.ObjectInserter; @@ -25,11 +30,6 @@ import org.eclipse.jgit.revwalk.RevTag; import org.eclipse.jgit.revwalk.RevTree; import org.eclipse.jgit.revwalk.RevWalk; -import org.eclipse.jgit.storage.dfs.DfsRepository; -import org.eclipse.jgit.storage.dfs.DfsRepositoryDescription; -import org.eclipse.jgit.storage.dfs.InMemoryRepository; - -import java.io.IOException; /** Unit tests for {@link TimeCache}. */ public class TimeCacheTest extends TestCase {
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/TreeSoyDataTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/TreeSoyDataTest.java index a0fa78a..e1ed3e8 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/TreeSoyDataTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/TreeSoyDataTest.java
@@ -16,13 +16,12 @@ import static com.google.gitiles.TreeSoyData.getTargetDisplayName; import static com.google.gitiles.TreeSoyData.resolveTargetUrl; - -import com.google.common.base.Strings; - import junit.framework.TestCase; import org.eclipse.jgit.lib.ObjectId; +import com.google.common.base.Strings; + /** Tests for {@link TreeSoyData}. */ public class TreeSoyDataTest extends TestCase { public void testGetTargetDisplayName() throws Exception {
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/ViewFilterTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/ViewFilterTest.java index 3f0b727..4386609 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/ViewFilterTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/ViewFilterTest.java
@@ -19,20 +19,6 @@ import static com.google.gitiles.GitilesFilter.REPO_REGEX; import static com.google.gitiles.GitilesFilter.ROOT_REGEX; -import com.google.common.collect.ImmutableList; -import com.google.common.util.concurrent.Atomics; -import com.google.gitiles.GitilesView.Type; - -import junit.framework.TestCase; - -import org.eclipse.jgit.http.server.glue.MetaFilter; -import org.eclipse.jgit.http.server.glue.MetaServlet; -import org.eclipse.jgit.junit.TestRepository; -import org.eclipse.jgit.revwalk.RevCommit; -import org.eclipse.jgit.storage.dfs.DfsRepository; -import org.eclipse.jgit.storage.dfs.DfsRepositoryDescription; -import org.eclipse.jgit.storage.dfs.InMemoryRepository; - import java.io.IOException; import java.util.concurrent.atomic.AtomicReference; import java.util.regex.Pattern; @@ -42,6 +28,20 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import junit.framework.TestCase; + +import org.eclipse.jgit.http.server.glue.MetaFilter; +import org.eclipse.jgit.http.server.glue.MetaServlet; +import org.eclipse.jgit.internal.storage.dfs.DfsRepository; +import org.eclipse.jgit.internal.storage.dfs.DfsRepositoryDescription; +import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository; +import org.eclipse.jgit.junit.TestRepository; +import org.eclipse.jgit.revwalk.RevCommit; + +import com.google.common.collect.ImmutableList; +import com.google.common.util.concurrent.Atomics; +import com.google.gitiles.GitilesView.Type; + /** Tests for the view filter. */ public class ViewFilterTest extends TestCase { private TestRepository<DfsRepository> repo;
diff --git a/pom.xml b/pom.xml index b5d5399..ebf4149 100644 --- a/pom.xml +++ b/pom.xml
@@ -32,7 +32,7 @@ <properties> <!-- Should track Gerrit's jgitVersion fairly closely. --> - <jgitVersion>2.3.1.201302201838-r.63-gbba74ba</jgitVersion> + <jgitVersion>2.3.1.201302201838-r.70-gf32b861</jgitVersion> <jettyVersion>7.6.8.v20121106</jettyVersion> <slf4jVersion>1.6.1</slf4jVersion> </properties>