tree ad1283095662ea0edf20f2736fa98c350af40e91
parent c77a18bb159c2e0e0b5f973f275ac442927696d1
author Dave Borowitz <dborowitz@google.com> 1469657472 -0400
committer Dave Borowitz <dborowitz@google.com> 1469657472 -0400

BlobSoyData: Remove special handling of \r

The only benefit of handling \r\n specially is to avoid emitting
"<td>foo\r</td>" for lines ending in \r\n. In practice, browsers don't
render the \r, so this is basically a non-issue.

The major downside of handling \r\n specially is that it disagrees
with the internals of JGit, which always assumes \n line endings.
There was a bug in the existing code that treated bare \r not followed
by \n as a newline, which broke the code in BlameServlet that assumes
the number of lines in the blame (from JGit internals) is the same as
in the BlobSoyData. Rather than fixing that bug by introducing more
complexity, we decided to go with the safest option, which is to match
JGit internals.

Change-Id: I4c96c3dc21260c13c311a6c018302d759c5b6e17