Remove ,n,z from links to *-review Change-Ids They don’t mean anything anymore. Change-Id: I7ed8974298ffb23410eaaa88b60f3577c7f30878
diff --git a/gitiles-servlet/src/main/java/com/google/gitiles/Linkifier.java b/gitiles-servlet/src/main/java/com/google/gitiles/Linkifier.java index e3110dd..27aff63 100644 --- a/gitiles-servlet/src/main/java/com/google/gitiles/Linkifier.java +++ b/gitiles-servlet/src/main/java/com/google/gitiles/Linkifier.java
@@ -102,7 +102,7 @@ if (baseGerritUrl != null) { CommentLinkInfo changeIds = - new CommentLinkInfo(CHANGE_ID_PATTERN, baseGerritUrl + "#/q/$0,n,z"); + new CommentLinkInfo(CHANGE_ID_PATTERN, baseGerritUrl + "#/q/$0"); operationalCommentLinks.add(changeIds); }
diff --git a/gitiles-servlet/src/test/java/com/google/gitiles/LinkifierTest.java b/gitiles-servlet/src/test/java/com/google/gitiles/LinkifierTest.java index 37ff436..baa9727 100644 --- a/gitiles-servlet/src/test/java/com/google/gitiles/LinkifierTest.java +++ b/gitiles-servlet/src/test/java/com/google/gitiles/LinkifierTest.java
@@ -102,19 +102,19 @@ assertThat(l.linkify(REQ, "I0123456789")) .containsExactly( ImmutableMap.of( - "text", "I0123456789", "url", "http://test-host-review/foo/#/q/I0123456789,n,z")) + "text", "I0123456789", "url", "http://test-host-review/foo/#/q/I0123456789")) .inOrder(); assertThat(l.linkify(REQ, "Change-Id: I0123456789")) .containsExactly( ImmutableMap.of("text", "Change-Id: "), ImmutableMap.of( - "text", "I0123456789", "url", "http://test-host-review/foo/#/q/I0123456789,n,z")) + "text", "I0123456789", "url", "http://test-host-review/foo/#/q/I0123456789")) .inOrder(); assertThat(l.linkify(REQ, "Change-Id: I0123456789 exists")) .containsExactly( ImmutableMap.of("text", "Change-Id: "), ImmutableMap.of( - "text", "I0123456789", "url", "http://test-host-review/foo/#/q/I0123456789,n,z"), + "text", "I0123456789", "url", "http://test-host-review/foo/#/q/I0123456789"), ImmutableMap.of("text", " exists")) .inOrder(); } @@ -147,7 +147,7 @@ "text", "http://my/url/I0123456789", "url", "http://my/url/I0123456789"), ImmutableMap.of("text", " is not change "), ImmutableMap.of( - "text", "I0123456789", "url", "http://test-host-review/foo/#/q/I0123456789,n,z")) + "text", "I0123456789", "url", "http://test-host-review/foo/#/q/I0123456789")) .inOrder(); }