blob: ab2b9b31b0bfe8acb168e8750f89499c5ae0608a [file] [log] [blame]
David Pursehouseb98f9c82018-09-23 12:58:27 +09001load(
2 "@bazel_tools//tools/jdk:default_java_toolchain.bzl",
3 "JDK9_JVM_OPTS",
4 "default_java_toolchain",
5)
David Pursehouse9d46aab2019-09-09 10:52:21 +09006load("@rules_java//java:defs.bzl", "java_package_configuration")
David Pursehouseb98f9c82018-09-23 12:58:27 +09007
8default_java_toolchain(
9 name = "error_prone_warnings_toolchain",
David Pursehouse65630312018-11-07 15:39:49 +090010 bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath.jar"],
David Pursehouseb98f9c82018-09-23 12:58:27 +090011 jvm_opts = JDK9_JVM_OPTS,
12 package_configuration = [
13 ":error_prone",
14 ],
15 visibility = ["//visibility:public"],
16)
17
David Pursehouse956bd7d2019-05-25 17:07:28 +090018# Error Prone errors enabled by default; see ../.bazelrc for how this is
19# enabled. This warnings list is originally based on:
David Pursehouseb98f9c82018-09-23 12:58:27 +090020# https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl
David Pursehouse956bd7d2019-05-25 17:07:28 +090021# However, feel free to add any additional errors. Thus far they have all been pretty useful.
David Pursehouseb98f9c82018-09-23 12:58:27 +090022java_package_configuration(
23 name = "error_prone",
24 javacopts = [
25 "-XepDisableWarningsInGeneratedCode",
David Pursehousec0dafc92019-05-25 17:19:44 +090026 "-Xep:AmbiguousMethodReference:ERROR",
27 "-Xep:BadAnnotationImplementation:ERROR",
28 "-Xep:BadComparable:ERROR",
David Pursehouseb98f9c82018-09-23 12:58:27 +090029 "-Xep:BoxedPrimitiveConstructor:ERROR",
David Pursehousec0dafc92019-05-25 17:19:44 +090030 "-Xep:CannotMockFinalClass:ERROR",
31 "-Xep:ClassCanBeStatic:ERROR",
32 "-Xep:ClassNewInstance:ERROR",
David Pursehoused30ae4c2019-06-05 15:30:37 +090033 "-Xep:DateFormatConstant:ERROR",
David Pursehouse00e3a292018-11-08 11:25:00 +090034 "-Xep:DefaultCharset:ERROR",
David Pursehousec0dafc92019-05-25 17:19:44 +090035 "-Xep:DoubleCheckedLocking:ERROR",
David Pursehousec0dafc92019-05-25 17:19:44 +090036 "-Xep:DoubleCheckedLocking:ERROR",
37 "-Xep:ElementsCountedInLoop:ERROR",
David Pursehouse2e9f8232019-06-05 15:18:01 +090038 "-Xep:ElementsCountedInLoop:ERROR",
David Pursehousec0dafc92019-05-25 17:19:44 +090039 "-Xep:EqualsHashCode:ERROR",
40 "-Xep:EqualsIncompatibleType:ERROR",
41 "-Xep:ExpectedExceptionChecker:ERROR",
42 "-Xep:Finally:ERROR",
43 "-Xep:FloatingPointLiteralPrecision:ERROR",
44 "-Xep:FragmentInjection:ERROR",
45 "-Xep:FragmentNotInstantiable:ERROR",
46 "-Xep:FunctionalInterfaceClash:ERROR",
47 "-Xep:FutureReturnValueIgnored:ERROR",
48 "-Xep:GetClassOnEnum:ERROR",
David Pursehouse5738d522019-06-05 13:40:18 +090049 "-Xep:ImmutableAnnotationChecker:ERROR",
David Pursehouseb98f9c82018-09-23 12:58:27 +090050 "-Xep:ImmutableEnumChecker:WARN",
David Pursehousec0dafc92019-05-25 17:19:44 +090051 "-Xep:IncompatibleModifiers:ERROR",
52 "-Xep:InjectOnConstructorOfAbstractClass:ERROR",
53 "-Xep:InputStreamSlowMultibyteRead:ERROR",
54 "-Xep:IterableAndIterator:ERROR",
55 "-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR",
56 "-Xep:JUnitAmbiguousTestClass:ERROR",
57 "-Xep:LiteralClassName:ERROR",
58 "-Xep:MissingCasesInEnumSwitch:ERROR",
59 "-Xep:MissingFail:ERROR",
60 "-Xep:MissingOverride:ERROR",
61 "-Xep:MutableConstantField:ERROR",
62 "-Xep:NarrowingCompoundAssignment:ERROR",
63 "-Xep:NonAtomicVolatileUpdate:ERROR",
64 "-Xep:NonOverridingEquals:ERROR",
65 "-Xep:NullableConstructor:ERROR",
66 "-Xep:NullablePrimitive:ERROR",
67 "-Xep:NullableVoid:ERROR",
68 "-Xep:OperatorPrecedence:ERROR",
69 "-Xep:OverridesGuiceInjectableMethod:ERROR",
70 "-Xep:PreconditionsInvalidPlaceholder:ERROR",
71 "-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR",
72 "-Xep:ProtocolBufferOrdinal:ERROR",
David Pursehouse9b844ae2019-06-05 13:46:59 +090073 "-Xep:ReferenceEquality:ERROR",
David Pursehousec0dafc92019-05-25 17:19:44 +090074 "-Xep:RequiredModifiers:ERROR",
75 "-Xep:ShortCircuitBoolean:ERROR",
76 "-Xep:SimpleDateFormatConstant:ERROR",
77 "-Xep:StaticGuardedByInstance:ERROR",
78 "-Xep:StringEquality:ERROR",
79 "-Xep:SynchronizeOnNonFinalField:ERROR",
80 "-Xep:TruthConstantAsserts:ERROR",
81 "-Xep:TypeParameterShadowing:ERROR",
82 "-Xep:TypeParameterUnusedInFormals:ERROR",
83 "-Xep:URLEqualsHashCode:ERROR",
84 "-Xep:UnsynchronizedOverridesSynchronized:ERROR",
85 "-Xep:WaitNotInLoop:ERROR",
86 "-Xep:WildcardImport:ERROR",
David Pursehouseb98f9c82018-09-23 12:58:27 +090087 ],
88 packages = ["error_prone_packages"],
89)
90
91package_group(
92 name = "error_prone_packages",
93 packages = [
94 "//java/...",
95 "//javatests/...",
96 ],
97)