| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 1 | load( |
| 2 | "@bazel_tools//tools/jdk:default_java_toolchain.bzl", |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 3 | "default_java_toolchain", |
| 4 | ) |
| David Pursehouse | 9d46aab | 2019-09-09 10:52:21 +0900 | [diff] [blame] | 5 | load("@rules_java//java:defs.bzl", "java_package_configuration") |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 6 | |
| 7 | default_java_toolchain( |
| David Ostrovsky | 2afae06 | 2022-01-08 09:39:06 +0100 | [diff] [blame] | 8 | name = "error_prone_warnings_toolchain_java11", |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 9 | package_configuration = [ |
| 10 | ":error_prone", |
| 11 | ], |
| David Ostrovsky | 3b35763 | 2022-05-11 12:42:59 +0200 | [diff] [blame] | 12 | source_version = "11", |
| 13 | target_version = "11", |
| 14 | visibility = ["//visibility:public"], |
| 15 | ) |
| 16 | |
| 17 | default_java_toolchain( |
| 18 | name = "error_prone_warnings_toolchain_java17", |
| 19 | configuration = dict(), |
| 20 | java_runtime = "@bazel_tools//tools/jdk:remotejdk_17", |
| 21 | package_configuration = [ |
| 22 | ":error_prone", |
| 23 | ], |
| 24 | source_version = "17", |
| 25 | target_version = "17", |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 26 | visibility = ["//visibility:public"], |
| 27 | ) |
| 28 | |
| David Pursehouse | 956bd7d | 2019-05-25 17:07:28 +0900 | [diff] [blame] | 29 | # Error Prone errors enabled by default; see ../.bazelrc for how this is |
| 30 | # enabled. This warnings list is originally based on: |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 31 | # https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl |
| David Pursehouse | 956bd7d | 2019-05-25 17:07:28 +0900 | [diff] [blame] | 32 | # However, feel free to add any additional errors. Thus far they have all been pretty useful. |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 33 | java_package_configuration( |
| 34 | name = "error_prone", |
| 35 | javacopts = [ |
| 36 | "-XepDisableWarningsInGeneratedCode", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 37 | "-Xep:AmbiguousMethodReference:ERROR", |
| 38 | "-Xep:BadAnnotationImplementation:ERROR", |
| 39 | "-Xep:BadComparable:ERROR", |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 40 | "-Xep:BoxedPrimitiveConstructor:ERROR", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 41 | "-Xep:CannotMockFinalClass:ERROR", |
| 42 | "-Xep:ClassCanBeStatic:ERROR", |
| 43 | "-Xep:ClassNewInstance:ERROR", |
| David Pursehouse | d30ae4c | 2019-06-05 15:30:37 +0900 | [diff] [blame] | 44 | "-Xep:DateFormatConstant:ERROR", |
| David Pursehouse | 00e3a29 | 2018-11-08 11:25:00 +0900 | [diff] [blame] | 45 | "-Xep:DefaultCharset:ERROR", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 46 | "-Xep:DoubleCheckedLocking:ERROR", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 47 | "-Xep:DoubleCheckedLocking:ERROR", |
| 48 | "-Xep:ElementsCountedInLoop:ERROR", |
| David Pursehouse | 2e9f823 | 2019-06-05 15:18:01 +0900 | [diff] [blame] | 49 | "-Xep:ElementsCountedInLoop:ERROR", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 50 | "-Xep:EqualsHashCode:ERROR", |
| 51 | "-Xep:EqualsIncompatibleType:ERROR", |
| 52 | "-Xep:ExpectedExceptionChecker:ERROR", |
| 53 | "-Xep:Finally:ERROR", |
| 54 | "-Xep:FloatingPointLiteralPrecision:ERROR", |
| 55 | "-Xep:FragmentInjection:ERROR", |
| 56 | "-Xep:FragmentNotInstantiable:ERROR", |
| 57 | "-Xep:FunctionalInterfaceClash:ERROR", |
| 58 | "-Xep:FutureReturnValueIgnored:ERROR", |
| 59 | "-Xep:GetClassOnEnum:ERROR", |
| David Pursehouse | 5738d52 | 2019-06-05 13:40:18 +0900 | [diff] [blame] | 60 | "-Xep:ImmutableAnnotationChecker:ERROR", |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 61 | "-Xep:ImmutableEnumChecker:WARN", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 62 | "-Xep:IncompatibleModifiers:ERROR", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 63 | "-Xep:InputStreamSlowMultibyteRead:ERROR", |
| 64 | "-Xep:IterableAndIterator:ERROR", |
| 65 | "-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR", |
| 66 | "-Xep:JUnitAmbiguousTestClass:ERROR", |
| 67 | "-Xep:LiteralClassName:ERROR", |
| 68 | "-Xep:MissingCasesInEnumSwitch:ERROR", |
| 69 | "-Xep:MissingFail:ERROR", |
| 70 | "-Xep:MissingOverride:ERROR", |
| 71 | "-Xep:MutableConstantField:ERROR", |
| 72 | "-Xep:NarrowingCompoundAssignment:ERROR", |
| 73 | "-Xep:NonAtomicVolatileUpdate:ERROR", |
| 74 | "-Xep:NonOverridingEquals:ERROR", |
| 75 | "-Xep:NullableConstructor:ERROR", |
| 76 | "-Xep:NullablePrimitive:ERROR", |
| 77 | "-Xep:NullableVoid:ERROR", |
| 78 | "-Xep:OperatorPrecedence:ERROR", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 79 | "-Xep:PreconditionsInvalidPlaceholder:ERROR", |
| 80 | "-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR", |
| 81 | "-Xep:ProtocolBufferOrdinal:ERROR", |
| David Pursehouse | 9b844ae | 2019-06-05 13:46:59 +0900 | [diff] [blame] | 82 | "-Xep:ReferenceEquality:ERROR", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 83 | "-Xep:RequiredModifiers:ERROR", |
| 84 | "-Xep:ShortCircuitBoolean:ERROR", |
| 85 | "-Xep:SimpleDateFormatConstant:ERROR", |
| 86 | "-Xep:StaticGuardedByInstance:ERROR", |
| 87 | "-Xep:StringEquality:ERROR", |
| 88 | "-Xep:SynchronizeOnNonFinalField:ERROR", |
| 89 | "-Xep:TruthConstantAsserts:ERROR", |
| 90 | "-Xep:TypeParameterShadowing:ERROR", |
| 91 | "-Xep:TypeParameterUnusedInFormals:ERROR", |
| 92 | "-Xep:URLEqualsHashCode:ERROR", |
| 93 | "-Xep:UnsynchronizedOverridesSynchronized:ERROR", |
| David Ostrovsky | 1ae7c38 | 2020-01-24 08:17:24 +0100 | [diff] [blame] | 94 | "-Xep:UnusedException:ERROR", |
| David Pursehouse | c0dafc9 | 2019-05-25 17:19:44 +0900 | [diff] [blame] | 95 | "-Xep:WaitNotInLoop:ERROR", |
| 96 | "-Xep:WildcardImport:ERROR", |
| David Pursehouse | b98f9c8 | 2018-09-23 12:58:27 +0900 | [diff] [blame] | 97 | ], |
| 98 | packages = ["error_prone_packages"], |
| 99 | ) |
| 100 | |
| 101 | package_group( |
| 102 | name = "error_prone_packages", |
| 103 | packages = [ |
| 104 | "//java/...", |
| 105 | "//javatests/...", |
| 106 | ], |
| 107 | ) |